Skip to content

Enable IDE0030: UseCoalesceExpressionForNullable - #14289

Merged
Rob Holt (rjmholt) merged 2 commits into
PowerShell:masterfrom
xtqqczze:IDE0030
Jul 13, 2021
Merged

Enable IDE0030: UseCoalesceExpressionForNullable#14289
Rob Holt (rjmholt) merged 2 commits into
PowerShell:masterfrom
xtqqczze:IDE0030

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 29, 2020

Copy link
Copy Markdown
Contributor

@xtqqczze
xtqqczze marked this pull request as ready for review November 29, 2020 14:34
iSazonov
Ilya (iSazonov) reviewed Nov 29, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs Outdated
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 29, 2020
@xtqqczze

xtqqczze commented Nov 30, 2020

Copy link
Copy Markdown
Contributor Author

Relates to #13791.

@xtqqczze
xtqqczze marked this pull request as draft December 2, 2020 11:53
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 5, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review December 11, 2020 21:55
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 19, 2020
@ghost

Deleted user (ghost) commented Dec 19, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

rjmholt
Rob Holt (rjmholt) approved these changes Apr 12, 2021
View reviewed changes
Comment thread src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs Outdated
@iSazonov

Ilya (iSazonov) commented Apr 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I would rather not merge this and close it until the analyzers are fixed otherwise it will have to be fixed a second time.

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 13, 2021
@xtqqczze

xtqqczze commented Apr 13, 2021

Copy link
Copy Markdown
Contributor Author

I would rather not merge this and close it until the analyzers are fixed otherwise it will have to be fixed a second time.

Ilya (@iSazonov) I don't think there is an issue with the IDE0030 analyzer - it is working as designed. If a new analyzer is approved to prefer Nullable<T>.GetValueOrDefault() as a result of dotnet/runtime#33792 we could consider new changes in that instance.

@ghost ghost added the Review - Needed The PR is being reviewed label Apr 21, 2021
@ghost

Deleted user (ghost) commented Apr 21, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

xtqqczze commented Jun 23, 2021

Copy link
Copy Markdown
Contributor Author

rebased

@rjmholt

Rob Holt (rjmholt) commented Jun 24, 2021

Copy link
Copy Markdown
Collaborator

/azp run

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 24, 2021
@azure-pipelines

azure-pipelines Bot commented Jun 24, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 6 pipeline(s).

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 2, 2021
@ghost

Deleted user (ghost) commented Jul 2, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt
Rob Holt (rjmholt) merged commit 00bc0f6 into PowerShell:master Jul 13, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 13, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.8 milestone Jul 13, 2021
@xtqqczze
xtqqczze deleted the IDE0030 branch July 14, 2021 12:12
@ghost

Deleted user (ghost) commented Jul 22, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable IDE0030: UseCoalesceExpressionForNullable (PowerShell#14289)
dbfaacd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

See More

@rjmholt Rob Holt (rjmholt)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @rjmholt