Enable nullable: System.Management.Automation.Provider.ICmdletProviderSupportsHelp - #14150
Merged
Ilya (iSazonov) merged 2 commits intoMay 18, 2021
Conversation
Staffan Gustafsson (powercode)
requested a review
from Andrew (anmenaga)
as a code owner
November 19, 2020 21:28
ghost
assigned
Staffan Gustafsson (powercode)
force-pushed
the
nullable/ICmdletProviderSupportsHelp
branch
from
November 19, 2020 21:31
a1ba215 to
2d1b3c2
Compare
Staffan Gustafsson (powercode)
force-pushed
the
nullable/ICmdletProviderSupportsHelp
branch
from
November 19, 2020 21:33
2d1b3c2 to
74ee1c5
Compare
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
| /// This interface needs to be implemented by providers that want users to see | ||
| /// provider-specific help. | ||
| /// </summary> | ||
| #nullable enable |
There was a problem hiding this comment.
💭 This seems a bit strange. I would expect to see it before the documentation comment.
| @@ -37,7 +39,7 @@ public interface ICmdletProviderSupportsHelp | |||
| [SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Maml", Justification = "Maml is an acronym.")] | |||
| string GetHelpMaml(string helpItemName, string path); | |||
There was a problem hiding this comment.
The documentation for this method does not specify what a null return value means. I would expect the implementations and callers of this interface to be annotated at the same time as this interface to ensure the pre- and post-conditions are correctly captured.
Steve Lee (SteveL-MSFT)
added
the
CL-CodeCleanup
Ilya (iSazonov)
approved these changes
May 18, 2021
Collaborator
|
/azp run PowerShell-CI-static-analysis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Staffan Gustafsson (powercode)
deleted the
nullable/ICmdletProviderSupportsHelp
branch
May 25, 2021 21:26
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #12631.