Skip to content

Fix whitespace issues#14092

Merged
iSazonov merged 1 commit into
PowerShell:masterfrom
xtqqczze:fix-whitespace
Nov 19, 2020
Merged

Fix whitespace issues#14092
iSazonov merged 1 commit into
PowerShell:masterfrom
xtqqczze:fix-whitespace

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Nov 14, 2020 •
edited
Loading

Fix some whitespace issues using dotnet-format

@xtqqczze xtqqczze requested a review from anmenaga as a code owner November 14, 2020 01:47
@ghost ghost assigned TravisEz13 Nov 14, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Nov 14, 2020

@iSazonov Please could you merge.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Nov 14, 2020

Test failures due to HTTP error 503 (Service Unavailable) in package restore. Since these are trivial changes, I will not restart tests.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Nov 14, 2020 •
edited by unfurl-links Bot
Loading

@xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

GitHub
PowerShell for every system! Contribute to iSazonov/PowerShell development by creating an account on GitHub.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Nov 15, 2020 •
edited
Loading

@xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Nov 15, 2020 •
edited
Loading

@xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.

Fix merged in #14094.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Nov 16, 2020

@xtqqczze Please rebase.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Nov 18, 2020

@iSazonov Pleases merge.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 19, 2020
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Nov 19, 2020
@iSazonov iSazonov merged commit c9df1c1 into PowerShell:master Nov 19, 2020
@xtqqczze xtqqczze deleted the fix-whitespace branch November 19, 2020 11:44
@ghost
Copy link
Copy Markdown

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @TravisEz13