Should an override be provided for GetHashCode() too?

It is not clear if we force the rule why does it not complain?

Should an override be provided for GetHashCode() too?

It is not clear if we force the rule why does it not complain?

We might expect to see compiler warning (level 3) CS0659 if the override for GetHashCode is missing. It appears we have level 5 warnings enabled.

Should an override be provided for GetHashCode() too?

It is not clear if we force the rule why does it not complain?

The method already exists: 😛
public override int GetHashCode()

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

I am not sure it is a breaking change.

I am not sure it is a breaking change.

According to .NET compatibility guidelines, probably not:

ALLOWED: Adding or removing an override

https://docs.microsoft.com/dotnet/core/compatibility/#members

Types of breaking changes - .NET Core

Learn how .NET Core attempts to maintain compatibility for developers across .NET versions, and what kind of change is considered a breaking change.

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Ask PowerShell Committee about adding new public API.

@PowerShell/powershell-committee reviewed this, we are ok taking the new public API, but a test needs to be added and we believe the current implementation may not be correct

@xtqqczze Please add some xUnit tests as Committee ask.

@iSazonov I do not know even where to begin with adding these tests :(

@xtqqczze xUnit tests are in test\xUnit\csharp folder. (You could look similar tests for Equals() in .Net Runtime repo.)

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author