Skip to content

Run dotnet-format to improve formatting of source code#13503

Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
xtqqczze:patch-dotnet-format2
Nov 4, 2020
Merged

Run dotnet-format to improve formatting of source code#13503
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
xtqqczze:patch-dotnet-format2

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

PR Summary

Reformat code according to EditorConfig rules.

The following rules were temporarily disabled as they resulted in a high number of changes:

dotnet_sort_system_directives_first = true
csharp_preserve_single_line_statements = false
csharp_new_line_before_open_brace = all

PR Context

Follow-up: #11681

PR Checklist

The following rules were disabled as they resulted in a high number of changes:

```
dotnet_sort_system_directives_first = true
csharp_preserve_single_line_statements = false
csharp_new_line_before_open_brace = all
```
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change introduced 4 new CodeFactor violations. Please fix them.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 25, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 28, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor Author

@adityapatwardhan CodeFactor violations are fixed.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 29, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 5, 2020
@ghost
Copy link
Copy Markdown

ghost commented Sep 5, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

This comment has been minimized.

@xtqqczze xtqqczze force-pushed the patch-dotnet-format2 branch from 094b1d5 to 5037e9d Compare October 30, 2020 21:43
@adityapatwardhan adityapatwardhan changed the title Run dotnet-format Run dotnet-format to improve formatting of source code Nov 4, 2020
@adityapatwardhan adityapatwardhan merged commit 52ecb6d into PowerShell:master Nov 4, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 4, 2020
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.1 milestone Nov 4, 2020
@xtqqczze xtqqczze deleted the patch-dotnet-format2 branch November 5, 2020 16:26
@ghost
Copy link
Copy Markdown

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants