Added Support For Big Endian UTF-32#11947
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Apr 7, 2020
Merged
Added Support For Big Endian UTF-32#11947adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
NoMoreFood
force-pushed
the
bigendian_utf32
branch
from
d66c9f8 to
2dea0d5
Compare
- Added support for big endian UTF-32 and common classes. - Updated relevant tests for big endian UTF-32. - Fixed test that was attempting to enumerate encoding types but was enumerating an empty set.
vexx32
suggested changes
Feb 25, 2020
Collaborator
vexx32
left a comment
vexx32
left a comment
There was a problem hiding this comment.
Nice work!
There's a few things we can do a bit better here, but overall this looks good. Thanks for adding this! 💖 😊
ghost
added
Waiting on Author
- Addressed review comments in test scripts.
Member
|
@JamesWTruher Can you please review this. |
adityapatwardhan
approved these changes
Apr 7, 2020
Member
|
@NoMoreFood Thank you for your contribution! |
adityapatwardhan
added
the
CL-General
|
🎉 Handy links: |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added Support For Big Endian UTF-32 to common encoding enumerations/classes.
PR Context
Big Endian UTF-32 is a somewhat common encoding and was supported under Windows PowerShell. This pull adds support for it and also addresses a small bug that resulted in a test being effectively skipped.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.