Generate guid for FormatViewDefinition InstanceId if not provided#11896
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Feb 20, 2020
Merged
Generate guid for FormatViewDefinition InstanceId if not provided#11896iSazonov merged 1 commit intoPowerShell:masterfrom
iSazonov merged 1 commit intoPowerShell:masterfrom
Conversation
ThomasNieto
approved these changes
Feb 20, 2020
iSazonov
approved these changes
Feb 20, 2020
iSazonov
added
the
CL-General
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
InstanceIdfor aFormatViewDefinitionis the key to help differentiate views with the same name for the same type. However, when using the constructor forFormatViewDefinitionthat doesn't take an InstanceId, it keeps the default guid value of all zeros. During export time, the cmdlet builds a dictionary with the InstanceId as the key and with multiple views with same key, you only get the first one. Fix is to generate a new guid for InstanceId if one is not provided.PR Context
Fix #11825
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.