Restore the PowerShellStreamType enum with an ObsoleteAttribute#11836
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Feb 12, 2020
Merged
Restore the PowerShellStreamType enum with an ObsoleteAttribute#11836adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
rjmholt
requested review from
JamesWTruher,
TravisEz13,
adityapatwardhan and
daxian-dbw
Collaborator
Author
|
CodeFactor issues are due to reusing previous documentation comments |
TravisEz13
added
the
CL-Engine
TravisEz13
approved these changes
Feb 12, 2020
daxian-dbw
reviewed
Feb 12, 2020
| /// It is not used by any other PowerShell API, and is now obsolete | ||
| /// and should not be used if possible. | ||
| /// </remarks> | ||
| [Obsolete("Formerly used in PowerShell Workflow. Use an integer or System.Management.Automation.Language.RedirectionStream instead.")] |
Member
There was a problem hiding this comment.
Use an integer or System.Management.Automation.Language.RedirectionStream instead.
@TravisEz13 and I discussed on this message, and we think it's better to not give a workaround here given that those 2 enums have different members and values.
How about change the message to This enum type was used only in PowerShell Workflow and is now obsolete.
And make sure specify true for the error parameter.
daxian-dbw
requested changes
Feb 12, 2020
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
make sure specify true for the error parameter.
ghost
added
the
Waiting on Author
ghost
removed
the
Waiting on Author
daxian-dbw
approved these changes
Feb 12, 2020
adityapatwardhan
approved these changes
Feb 12, 2020
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Feb 18, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #11619.
PR Context
Returns the
PowerShellStreamTypeenum to code, since it was public, generically named and removed. Adds anObsoleteAttributeto prevent new usage.