Skip to content

Fixes: Build.psm1#11572

Merged
TravisEz13 merged 5 commits intoPowerShell:masterfrom
xtqqczze:build.psm1
Jan 15, 2020
Merged

Fixes: Build.psm1#11572
TravisEz13 merged 5 commits intoPowerShell:masterfrom
xtqqczze:build.psm1

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Jan 13, 2020

PR Summary

  • Fix typos
  • Refactor code for readability and robustness
  • Fix PSUseCmdletCorrectly rule violations

PR Context

During #11563 issues were uncovered, hence this PR.

PR Checklist

@TravisEz13
Copy link
Copy Markdown
Member

Was this tested on Windows PowerShell?

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned anmenaga Jan 14, 2020
Comment thread build.psm1
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 14, 2020
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 14, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Jan 14, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 14, 2020
@TravisEz13 TravisEz13 merged commit ba9a7b1 into PowerShell:master Jan 15, 2020
@xtqqczze xtqqczze deleted the build.psm1 branch February 4, 2020 23:52
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants