Avoid variable names that conflict with automatic variables#11392
Merged
anmenaga merged 2 commits intoPowerShell:masterfrom Dec 20, 2019
Merged
Avoid variable names that conflict with automatic variables#11392anmenaga merged 2 commits intoPowerShell:masterfrom
anmenaga merged 2 commits intoPowerShell:masterfrom
Conversation
xtqqczze
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
ghost
assigned
iSazonov
approved these changes
Dec 18, 2019
iSazonov
added
the
CL-Tools
|
@xtqqczze As far as i understand, this is a workaround for a problem in PSScriptAnalyzer, so it would be good to add an issue fro PSScriptAnalyzer for this. |
anmenaga
approved these changes
Dec 20, 2019
Contributor
Author
|
@anmenaga I think this is expected behavior, as per AvoidAssignmentToAutomaticVariable rule documentation.
|
8 tasks
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Avoid variable names that conflict with automatic variables.
PR Context
Variable names such as $error and $pid cause a PSScriptAnalyzer rule violation of type AvoidAssignmentToAutomaticVariable
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.