Skip to content

Add back Out-Printer command #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 8 commits into from
Nov 1, 2019
Merged

Add back Out-Printer command #10906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
551376d
add back Out-Printer command
SteveL-MSFT Oct 26, 2019
b4b32eb
fix test
SteveL-MSFT Oct 27, 2019
dea4bb8
remove lp alias and update fwlink
SteveL-MSFT Oct 29, 2019
b12b9fd
update help test
SteveL-MSFT Oct 29, 2019
8361d50
add back lp alias test, but only for FullWindows
SteveL-MSFT Oct 29, 2019
f468a30
Update test/powershell/engine/Basic/DefaultCommands.Tests.ps1
SteveL-MSFT Oct 29, 2019
8af8ae6
Update test/powershell/engine/Basic/DefaultCommands.Tests.ps1
SteveL-MSFT Oct 29, 2019
a0971e5
Merge branch 'master' of github.com:PowerShell/PowerShell into out-pr…
SteveL-MSFT Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,14 @@
</PropertyGroup>

<ItemGroup>
<Compile Remove="commands\utility\FormatAndOutput\out-printer\PrinterLineOutput.cs" />
<Compile Remove="commands\utility\FormatAndOutput\out-printer\Out-Printer.cs" />
<Compile Remove="singleshell\installer\MshUtilityMshSnapin.cs" />
<Compile Remove="gen\UtilityMshSnapinResources.cs" />
<Compile Remove="gen\OutPrinterDisplayStrings.cs" />
<Compile Remove="gen\ConvertFromStringResources.cs" />
<Compile Remove="gen\ConvertStringResources.cs" />
<Compile Remove="gen\FlashExtractStrings.cs" />
<Compile Remove="gen\ImmutableStrings.cs" />

<EmbeddedResource Remove="resources\UtilityMshSnapinResources.resx" />
<EmbeddedResource Remove="resources\OutPrinterDisplayStrings.resx" />
<EmbeddedResource Remove="resources\ConvertFromStringResources.resx" />
<EmbeddedResource Remove="resources\ConvertStringResources.resx" />
<EmbeddedResource Remove="resources\FlashExtractStrings.resx" />
Expand All @@ -37,6 +33,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" />
<PackageReference Include="System.Threading.AccessControl" Version="4.7.0-preview1.19504.10" />
<PackageReference Include="System.Drawing.Common" Version="4.7.0-preview1.19504.10" />
<PackageReference Include="NJsonSchema" Version="10.0.27" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion ...t.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/out-printer/Out-Printer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.PowerShell.Commands
/// <summary>
/// Implementation for the out-printer command.
/// </summary>
[Cmdlet(VerbsData.Out, "Printer", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=113367")]
[Cmdlet(VerbsData.Out, "Printer", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=2109553")]
public class OutPrinterCommand : FrontEndCommandBase
{
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Modules/Windows/Microsoft.PowerShell.Utility/Microsoft.PowerShell.Utility.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ CmdletsToExport = @(
'Add-Type', 'Get-TypeData', 'Remove-TypeData', 'Update-TypeData', 'Get-UICulture', 'Get-Unique', 'Get-Uptime',
'Clear-Variable', 'Get-Variable', 'New-Variable', 'Remove-Variable', 'Set-Variable', 'Get-Verb', 'Write-Verbose',
'Write-Warning', 'Invoke-WebRequest', 'Format-Wide', 'ConvertTo-Xml', 'Select-Xml', 'Get-Error', 'Update-List',
'Out-GridView', 'Show-Command'
'Out-GridView', 'Show-Command', 'Out-Printer'
)
FunctionsToExport = @()
AliasesToExport = @('fhx')
Expand Down
1 change: 0 additions & 1 deletion src/System.Management.Automation/engine/InitialSessionState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4621,7 +4621,6 @@ internal static SessionStateAliasEntry[] BuiltInAliases
new SessionStateAliasEntry("sc", "Set-Content", string.Empty, ReadOnly),
new SessionStateAliasEntry("swmi", "Set-WMIInstance", string.Empty, ReadOnly),
new SessionStateAliasEntry("trcm", "Trace-Command", string.Empty, ReadOnly),
new SessionStateAliasEntry("lp", "Out-Printer"),
#endif
// Aliases transferred from the profile
new SessionStateAliasEntry("h", "Get-History"),
Expand Down
6 changes: 3 additions & 3 deletions test/powershell/engine/Basic/DefaultCommands.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ Describe "Verify approved aliases list" -Tags "CI" {
"Cmdlet", "Out-Host", "", $($FullCLR -or $CoreWindows -or $CoreUnix), "", "", "None"
"Cmdlet", "Out-LineOutput", "", $($FullCLR ), "", "", ""
"Cmdlet", "Out-Null", "", $($FullCLR -or $CoreWindows -or $CoreUnix), "", "", "None"
"Cmdlet", "Out-Printer", "", $($FullCLR ), "", "", ""
"Cmdlet", "Out-Printer", "", $($FullCLR -or $CoreWindows ), "", "", "None"
"Cmdlet", "Out-String", "", $($FullCLR -or $CoreWindows -or $CoreUnix), "", "", "None"
"Cmdlet", "Pop-Location", "", $($FullCLR -or $CoreWindows -or $CoreUnix), "", "", "None"
"Cmdlet", "Protect-CmsMessage", "", $($FullCLR -or $CoreWindows ), "", "", "None"
Expand Down Expand Up @@ -523,8 +523,8 @@ Describe "Verify approved aliases list" -Tags "CI" {
if ($isPreview) {
$emptyConfigPath = Join-Path -Path $TestDrive -ChildPath "test.config.json"
Set-Content -Path $emptyConfigPath -Value "" -Force -ErrorAction Stop
$currentAliasList = pwsh -out XML -SettingsFile $emptyConfigPath -Command $getAliases -args ($moduleList | ConvertTo-Json)
$currentCmdletList = pwsh -out XML -SettingsFile $emptyConfigPath -Command $getCommands -args ($moduleList | ConvertTo-Json)
$currentAliasList = pwsh -NoProfile -OutputFormat XML -SettingsFile $emptyConfigPath -Command $getAliases -args ($moduleList | ConvertTo-Json)
$currentCmdletList = pwsh -NoProfile -OutputFormat XML -SettingsFile $emptyConfigPath -Command $getCommands -args ($moduleList | ConvertTo-Json)
}
else {
$currentAliasList = & $getAliases $moduleList
Expand Down
2 changes: 1 addition & 1 deletion test/powershell/engine/Help/assets/HelpURI/V2Cmdlets.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ Out-File,https://go.microsoft.com/fwlink/?LinkID=113363
Out-GridView,https://go.microsoft.com/fwlink/?LinkID=2109378
Out-Host,https://go.microsoft.com/fwlink/?LinkID=113365
Out-Null,https://go.microsoft.com/fwlink/?LinkID=113366
Out-Printer,https://go.microsoft.com/fwlink/?LinkID=113367
Out-Printer,https://go.microsoft.com/fwlink/?LinkID=2109553
Out-String,https://go.microsoft.com/fwlink/?LinkID=113368
Pop-Location,https://go.microsoft.com/fwlink/?LinkID=113369
Push-Location,https://go.microsoft.com/fwlink/?LinkID=113370
Expand Down