Skip to content

Set the output encoding to [Console]::OutputEncoding for native commands #10824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Oct 19, 2019
Merged

Set the output encoding to [Console]::OutputEncoding for native commands #10824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/System.Management.Automation/engine/NativeCommandProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,11 +1101,13 @@ private ProcessStartInfo GetProcessStartInfo(bool redirectOutput, bool redirectE
if (redirectOutput)
Comment thread
SteveL-MSFT marked this conversation as resolved.
Outdated
Comment thread
SteveL-MSFT marked this conversation as resolved.
Outdated
{
startInfo.RedirectStandardOutput = true;
startInfo.StandardOutputEncoding = Console.OutputEncoding;
}

if (redirectError)
{
startInfo.RedirectStandardError = true;
startInfo.StandardErrorEncoding = Console.OutputEncoding;
}
}
else
Expand Down
12 changes: 12 additions & 0 deletions test/powershell/Language/Scripting/NativeExecution/NativeCommandProcessor.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,18 @@ Describe "Native Command Processor" -tags "Feature" {
$ps.Dispose()
}
}

It "OutputEncoding should be used" -Skip:(!$IsWindows -or !(Get-Command sfc.exe)) {

$originalOutputEncoding = [Console]::OutputEncoding
try {
[Console]::OutputEncoding = [System.Text.Encoding]::Unicode
sfc | Out-String | Should -Not -Match "`0"
Comment thread
iSazonov marked this conversation as resolved.
Outdated
}
finally {
[Console]::OutputEncoding = $originalOutputEncoding
}
}
}

Describe "Open a text file with NativeCommandProcessor" -tags @("Feature", "RequireAdminOnWindows") {
Expand Down