Make PowerShell slash-agnostic on Linux#1081
Merged
andyleejordan merged 8 commits intomasterfrom Jun 15, 2016
Merged
Conversation
andyleejordan
changed the title
Collaborator
There was a problem hiding this comment.
just to be over the top, i expect the following tests should be done as follows:
It "Should work with backslashes for each separator" {
$testPath = "$TestDrive\testFile.txt".Replace("/","\")
Get-Content $testPath | should be $data
}
It "Should work with backslashes for each separator" {
$testPath = "$TestDrive/testFile.txt".Replace("\","/")
Get-Content $testPath | should be $data
}
It "should work even if there are too many slashes" {
$testPath = "$TestDrive//////testFile.txt"
Get-Content $testPath | should be $data
}
It "should work even if there are too many backslashes" {
$testPath = "$TestDrive\\\\\\\testFile.txt"
Get-Content $testPath | should be $data
}
Member
Author
There was a problem hiding this comment.
Why does a lot of slashes work?
Collaborator
|
Does this change include escaping to allow use "foo\bar" as a file-name on Linux as |
Member
Author
|
Collaborator
|
LGTM, @lzybkr can you take a look? |
Member
Author
|
This branch has more WIP, stripping out normalization and handling it explicitly for escaped backslashes. Major WIP but any pointers would welcome, it's gonna be tricky. |
Member
Author
|
@JamesWTruher I think we need to sit-down and design how we're going to handle the escaping. There are a few options. |
andyleejordan
force-pushed
the
andschwa/slash-agnostic
branch
2 times, most recently
from
e141096 to
0232f16
Compare
Because normalization of paths occurs through the location globber and filesystem provider by way of `path.Replace(alternate, default)`, changing the alternate path separator on Linux to be '\' instead of .NET's '/' let's PowerShell be "slash agnostic."
Assuming the path may not be normalized, to make PowerShell slash
agnostic in a filesystem whose "drive" is a '/' and a 'C:\', we need to
compare to both '/' and '\' for users of PowerShell's alternate path
separator on Linux ('\').
Reverted to original code and fixed correctly.
Reverted to original code and fixed correctly.
These comparisons did not need to be changed as the input path is not modified. The normalized relate path created from the stack (if this code path is taken) is created with the correct path separators.
Member
Author
|
@vors I added the known issue for the current behavior. Do you sign-off? |
Collaborator
|
@andschwa yes, sign off |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #570.
PowerShell cmdlets now accept both '/' and '' as directory separators on Linux.
This is work in progress as now I need to get escaping of backslashes to work correctly.