Skip to content

Bump Microsoft.ApplicationInsights from 2.10.0 to 2.11.0 #10608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 2 commits into from
Oct 16, 2019
Merged

Bump Microsoft.ApplicationInsights from 2.10.0 to 2.11.0 #10608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b4358
Bump Microsoft.ApplicationInsights from 2.10.0 to 2.11.0
dependabot-preview[bot] Sep 23, 2019
06dace1
Add new style of telemetry client instatiation
JamesWTruher Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/System.Management.Automation.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<!-- the following package(s) are from https://github.com/JamesNK/Newtonsoft.Json -->
<PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
<!-- the Application Insights package -->
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.10.0" />
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.11.0" />
<!-- the following package(s) are from https://github.com/dotnet/corefx -->
<PackageReference Include="Microsoft.Win32.Registry.AccessControl" Version="4.6.0" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="4.6.0" />
Expand Down
8 changes: 5 additions & 3 deletions src/System.Management.Automation/utils/Telemetry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,13 @@ static ApplicationInsightsTelemetry()
CanSendTelemetry = !Utils.GetOptOutEnvVariableAsBool(name: _telemetryOptoutEnvVar, defaultValue: false);
if (CanSendTelemetry)
{
s_telemetryClient = new TelemetryClient();
TelemetryConfiguration.Active.InstrumentationKey = _psCoreTelemetryKey;
TelemetryConfiguration configuration = TelemetryConfiguration.CreateDefault();
configuration.InstrumentationKey = _psCoreTelemetryKey;

// Set this to true to reduce latency during development
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style:

Suggested change
// Set this to true to reduce latency during development
// Set this to true to reduce latency during development

TelemetryConfiguration.Active.TelemetryChannel.DeveloperMode = false;
configuration.TelemetryChannel.DeveloperMode = false;

s_telemetryClient = new TelemetryClient(configuration);
s_sessionId = Guid.NewGuid().ToString();

// use a hashset when looking for module names, it should be quicker than a string comparison
Expand Down