Skip to content

Update PSDesiredStateConfiguration to 2.0.3 and bring new tests.#10516

Merged
TravisEz13 merged 9 commits intoPowerShell:masterfrom
TravisEz13:psdsc-mod-update
Sep 12, 2019
Merged

Update PSDesiredStateConfiguration to 2.0.3 and bring new tests.#10516
TravisEz13 merged 9 commits intoPowerShell:masterfrom
TravisEz13:psdsc-mod-update

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Sep 11, 2019 •
edited
Loading

PR Summary

Update PSDesiredStateConfiguration to 2.0.3 and bring new tests.

PR Context

Adds Invoke-DscResource as an experimental feature and fixes to Get-DscResource

PR Checklist

@TravisEz13 TravisEz13 mentioned this pull request Sep 11, 2019
Closed
8 tasks
SteveL-MSFT
SteveL-MSFT requested changes Sep 11, 2019
View reviewed changes
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1 Outdated
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
It "The module should have $expectedCommandCount commands" {
if($commands.Count -ne $expectedCommandCount)
{
$modulePath = (Get-Module PSDesiredStateConfiguration).Path
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider creating a custom Pester assert instead of this debugging code, see https://github.com/PowerShell/PowerShell/pull/10228/files#diff-dd4e6955f1eab52dcef94ce16dc3c3a5R137 for an example

Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
Comment thread test/powershell/Modules/PSDesiredStateConfiguration/PSDesiredStateConfiguration.Tests.ps1
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 11, 2019
PoshChan
PoshChan reviewed Sep 11, 2019
View reviewed changes
Comment thread build.psm1 Outdated
PoshChan
PoshChan reviewed Sep 11, 2019
View reviewed changes
Comment thread build.psm1 Outdated
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 11, 2019
PoshChan
PoshChan reviewed Sep 11, 2019
View reviewed changes
Comment thread build.psm1 Outdated
@TravisEz13 TravisEz13 mentioned this pull request Sep 11, 2019
Open
@TravisEz13
Copy link
Copy Markdown
Member Author

TravisEz13 commented Sep 11, 2019 •
edited
Loading

@SteveL-MSFT Filed Issue 33 in PSDesiredStateConfiguration to address most of your comments as they are for code that does not live in this repo.

PoshChan
PoshChan reviewed Sep 11, 2019
View reviewed changes
Comment thread build.psm1 Outdated
PoshChan
PoshChan reviewed Sep 11, 2019
View reviewed changes
Comment thread build.psm1 Outdated
@TravisEz13 TravisEz13 mentioned this pull request Sep 11, 2019
Closed
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.4 milestone Sep 11, 2019
@TravisEz13 TravisEz13 added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CL-Experimental Indicates that a PR should be marked as an Experimental Feature in the Change Log AutoMerge informs the bot to automerge the PR labels Sep 11, 2019
@ghost
Copy link
Copy Markdown

ghost commented Sep 11, 2019

Hello @TravisEz13!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 24 hours, a condition that will be fulfilled in about 21 hours 42 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@TravisEz13 TravisEz13 marked this pull request as ready for review September 11, 2019 23:53
PoshChan
PoshChan reviewed Sep 12, 2019
View reviewed changes
Comment thread build.psm1
@TravisEz13 TravisEz13 removed the AutoMerge informs the bot to automerge the PR label Sep 12, 2019
@TravisEz13
Copy link
Copy Markdown
Member Author

TravisEz13 commented Sep 12, 2019

@PoshChan Please remind me in 30 minutes.

@mi-hol
Copy link
Copy Markdown

mi-hol commented Sep 12, 2019 •
edited by TravisEz13
Loading

@TravisEz13 the URL (Actual URL removed by @TravisEz13) in comment gives a 404 error.

@TravisEz13
Copy link
Copy Markdown
Member Author

TravisEz13 commented Sep 12, 2019 •
edited
Loading

@mi-hol PSDesiredStateConfiguration is closed source. This is expected unless you are a member of that project. I've removed the actual URL in my comment and yours to avoid future confusion.

PoshChan
PoshChan reviewed Sep 12, 2019
View reviewed changes
Comment thread assets/files.wxs
@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Sep 12, 2019

@TravisEz13, this is the reminder you requested 30 minutes. ago

daxian-dbw
daxian-dbw reviewed Sep 12, 2019
View reviewed changes
Comment thread build.psm1 Outdated
Comment thread build.psm1
@TravisEz13 TravisEz13 merged commit 60ffea5 into PowerShell:master Sep 12, 2019
@TravisEz13 TravisEz13 deleted the psdsc-mod-update branch September 12, 2019 21:39
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Sep 14, 2019
@TravisEz13
Update PSDesiredStateConfiguration to 2.0.3 and bring new test… (Powe…
8605f23 
…rShell#10516)
@anmenaga anmenaga removed the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 17, 2019
@ghost
Copy link
Copy Markdown

ghost commented Sep 19, 2019

🎉v7.0.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@sdwheeler sdwheeler mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Experimental Indicates that a PR should be marked as an Experimental Feature in the Change Log

Projects

None yet

Milestone

7.0.0-preview.4

Development

Successfully merging this pull request may close these issues.

6 participants

@TravisEz13 @mi-hol @PoshChan @daxian-dbw @SteveL-MSFT @anmenaga