While working on the sxs module path, I found some method names are intuitive, for example, GetDscModulePath() actually returns the Program Files shared module path, GetSystemWideModulePath() actually returns the pshome module path. Those method need to be renamed.
While working on the sxs module path, I found some method names are intuitive, for example,
GetDscModulePath()actually returns theProgram Filesshared module path,GetSystemWideModulePath()actually returns the pshome module path. Those method need to be renamed.powershellfile in the parent folder, but maybe checkpowershell.deps.jsonfile as well, and also the short folder name of the path should beModules. The current detection logic casued a test to fail in Travis CI, see Fix the test that fails in Travis CI build #1792Think about the nameinboxofPlatform.IsInboxproperty. Do we need a better name?Platform.IsInboxis an internal property, and it's well commented to clarify its meaning. We will keep this name unless there is a big concern about it.