Update wiki validation workflow#1220
Open
Andre601 wants to merge 4 commits into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
This is one of two Pull requests adressing an issue with the Wiki validation system.
The wiki validation system in its old form allows the execution of python code through custom extensions, hooks or plugins using priviledged permissions to do so.
This PR removes the comment part of the validation and also changes its permissions to be purely read-only.
Additionally does it add
persist-credentials: falseto not keep credentials after the checkout.This should limit the validation to the only necessary stuff, removing the risk of abuse.
It also changes the publish_site workflow to only trigger on specific file paths rather than anything except readme, as it could cause failed runs or unecessary deployments for changes made to unrelated files.