Make the shadow root optional#99
Merged
jackfranklin merged 1 commit intoFeb 14, 2019
Merged
Conversation
Closed
Member
|
Making this configurable is great. 👍 Could we keep shadow DOM as the default and make disabling it optional? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shadow DOM feature is cool, but it's pretty restrictive as a default
By being in a shadow DOM you cannot access CSS styles added to the document root (which your React project will be extracting to, if you're using something like
ExtractTextPlugin)