This repository was archived by the owner on Mar 8, 2024. It is now read-only.
fix: Verifiable PayID JWS Consumable - #661
Merged
Merged
Conversation
nhartner
reviewed
Aug 17, 2020
| */ | ||
| interface VerifiedAddress { | ||
| readonly payload: VerifiedAddressPayload | ||
| readonly payload: VerifiedAddressPayload | string |
Collaborator
There was a problem hiding this comment.
Do we still need to keep this as VerifiedAddressPayLoad | string vs just string?
Collaborator
There was a problem hiding this comment.
think this might have been a leftover from the last minute changes to make the demo work
0xASK
approved these changes
Aug 17, 2020
0xCLARITY
approved these changes
Aug 17, 2020
0xCLARITY
left a comment
0xCLARITY
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, pending Neil's comment.
nhartner
approved these changes
Aug 17, 2020
sasaki-san
pushed a commit
to jxpug/payid-serverless
that referenced
this pull request
Nov 16, 2020
* fixes * test: update tests to use strinfied json * drop unused type Co-authored-by: Hans Bergren <[email protected]>
sasaki-san
added a commit
to jxpug/payid-serverless
that referenced
this pull request
Nov 16, 2020
This reverts commit 209990d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Outputs verifiable PayID payloads as stringified JSON, instead of JSON.
Context of Change
After discussing with @nhartner, I learned that the
payloadneeds to bestringified JSON, so that it can be verified as a JWS ( as per RFC7797 ).
Type of Change
Before / After
Updates protocol output, and relevant tests
Test Plan
No new tests needed