Skip to content

Fix: class function TAccountComp.EqualOperationBlocks#253

Closed
SkybuckFlying wants to merge 14 commits into
PascalCoinDev:masterfrom
SkybuckFlying:PascalCoinMaster
Closed

Fix: class function TAccountComp.EqualOperationBlocks#253
SkybuckFlying wants to merge 14 commits into
PascalCoinDev:masterfrom
SkybuckFlying:PascalCoinMaster

Conversation

@SkybuckFlying

Copy link
Copy Markdown
Contributor

Compare block 1 vs block 2.

Quotes creates problems in bash cmd and powershell.
This script CreateSpacesToTabsFilter.sh creates a git filter
for this git repository to:

1. Convert two spaces to one tab on checkouts.
2. Convert one tab to two spaces on commits.

It needs GNU32CoreWinUtils to be installed.

The bin folder should be added to the OS/Windows path environment variable such
that expand.exe and unexpand.exe can be found and run/executed.
Creates advanced repository for working with tab characters.
@ctriroli

Copy link
Copy Markdown

Could Albert comment on this? I totally agree that it should be changed if we are aiming for an equality check - but of course there might be some hidden knowledge on Alberts side if the blocknumber could be unequal in case of harforksituations or so?

@PascalCoinDev

PascalCoinDev commented Feb 22, 2022

Copy link
Copy Markdown
Owner

Totally agree with the Result := (opBlock1.block = opBlock2.block) fixed bug at UAccounts.pas thanks SkybuckFlying, good job!

What I don't understand is what are the extra files you're adding to root folder... Can you explain some examples of what are they used for?

Also, note, if you do a pull request to fix a bug, please INSERT ONLY the changes that fixes it, not adding extra files that someone can think are malicious extra code.... do you understand, don't?

@PascalCoinDev

Copy link
Copy Markdown
Owner

Totally agree with the Result := (opBlock1.block = opBlock2.block) fixed bug at UAccounts.pas thanks SkybuckFlying, good job!

What I don't understand is what are the extra files you're adding to root folder... Can you explain some examples of what are they used for?

Also, note, if you do a pull request to fix a bug, please INSERT ONLY the changes that fixes it, not adding extra files that someone can think are malicious extra code.... do you understand, don't?

I'm open to add those extra *.sh files but please explain me an example of what they do in order to understand... thks

@PascalCoinDev PascalCoinDev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed comparision bug

@SkybuckFlying

Copy link
Copy Markdown
Contributor Author

These *.sh are script files, can also be renamed to *.bat so they can be executed by ms-dos command prompt in windows.

These scripts are ment to re-create local repositories, they basically clone the github repository.

This is handy for me in case I want to try risky changes to the git repository or want to do experimental things in git or to the sources.

Prevents me from having to lookup all these git commands, it just automates it.

One script creates a normal repository which is called:

CreatePascalCoinRepository.sh

It all creates some remotes and some branches to follow PascalCoin and PascalCoinDev github repos.

Another one is:

CreateAdvancedRepository.sh

Though I have not updated it in a while, it's probably broken but might still work, creates a mirror/repo/exact copy of my repo or whatever the url is, and allows to work with multiple checkouts (in different folders) which is very handy

My main script right now is this one, love it:
CreateAdvancedRepositoryTabbed.sh

^This script adds filters to automatically convert tabs to spaces and back again for faster editting of code.

And finally:

CreateSpacesToTabsFilter.sh

^

Here the commands to convert tabs to spaces and back were isolated but probably doesn't work too well.

The two best scripts are:

CreatePascalCoinRepository.sh

and

CreateAdvancedRepositoryTabbed.sh

For me it's handy to have them in my main master branch so when I do any kind of git clone it auto downloads them.

So then I can get to these scripts and then I can run them again to create a more advanced git repo.

Finally here is a little video of CreatePascalCoinRepository.sh script of an earlier version how to use it:

https://youtu.be/fn6X3pAf0NE

Maybe these two videos of git workflow can also help:

https://youtu.be/o-MCuRWZoOE

https://youtu.be/v8YiX8tsvFs

Bye for now,
Skybuck.

@PascalCoinDev

Copy link
Copy Markdown
Owner

Fixed bug commit has beed added using cherry-pick process
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants