Repository navigation
config: add missing functions for completeness - #112
Merged
Merged
Conversation
Member
|
This is awesome can you add tests for this? |
Contributor
Author
|
Holiday is over, not sure I'll have the freedom anytime soon :-| |
MichaelMure
force-pushed
the
complete-config
branch
from
August 27, 2020 11:54
1c7c34c to
b40ca79
Compare
Contributor
Author
|
@Invincibot added the needed tests, can we merge ? |
Contributor
Author
|
CI failure is unrelated to this PR. |
Contributor
Author
|
Anyone? |
Member
|
Sorry for the delay, weird times. |
Contributor
Author
|
Thank you :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complete the Config functions.
Add Options.Has to check if an Option exist.
Wherever a collection of Option exist, make sure that the following functions exists as well:
For Config and Section, make sure that the following exist to access the sublevel:
This PR also does some shuffling to have a consistent ordering of functions.