Feature/lv upgrade - #1
Merged
Merged
Conversation
allowed to set up created_by Signed-off-by: [email protected] <[email protected]> Change-Id: I4f3c7f914420d7cc3f7ed43204d0a951d295f7dd
* from 5.6.x to 5.7.x * from 5.7.x to 5.8.x * from 5.8.x to 6.x * from 6.x to 7.x * from 7.x to 8.x * php 7.4 support * mysql 8.x support Change-Id: I10a0a626363be3769ba70653b4943eaa2f2fb0b7 Signed-off-by: smarcet <[email protected]>
smarcet
added a commit
that referenced
this pull request
Jul 21, 2026
…nique name SummitMediaFileTypeService::update() reused the $type variable for a name-uniqueness check, overwriting the entity fetched via getById($id). When the payload's new name did not already exist in the DB, getByName() returned null, clobbering $type and causing SummitMediaFileTypeFactory::populate() to blow up with: TypeError: populate(): Argument #1 ($type) must be of type models\summit\SummitMediaFileType, null given The uniqueness check now uses its own $existing_type variable instead of overwriting the entity being updated.
smarcet
added a commit
that referenced
this pull request
Jul 21, 2026
…nique name SummitMediaFileTypeService::update() reused the $type variable for a name-uniqueness check, overwriting the entity fetched via getById($id). When the payload's new name did not already exist in the DB, getByName() returned null, clobbering $type and causing SummitMediaFileTypeFactory::populate() to blow up with: TypeError: populate(): Argument #1 ($type) must be of type models\summit\SummitMediaFileType, null given The uniqueness check now uses its own $existing_type variable instead of overwriting the entity being updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.