Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OpenStackweb/summit-api
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: OpenStackweb/summit-api
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: production
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 9 files changed
  • 1 contributor

Commits on Jul 25, 2026

  1. fix: dispatch original entity id in DeletedEventDTO, not a post-flush… 

    … getId() (#575)

Doctrine nulls an entity's identifier field via reflection after a hard
delete is flushed (UnitOfWork::executeDeletions). DeletedEventDTO::fromEntity()
was being called after the owning transaction closed, so it read that
stale, zeroed id and dispatched 'id' => 0 in the domain event payload.

Added DeletedEventDTO::fromId() and switched the affected dispatch call
sites to build the DTO from the id captured before removal:

- SummitSponsorshipService::removeSponsorship / removeAddOn
- SummitSponsorService::deleteSponsor
- SummitMediaFileTypeService::delete

Also applied the same fromId() call in SummitService::deleteSummit for
consistency, though that path only flips a soft-delete flag (no
em->remove()), so it never actually reproduced the zeroed-id bug.

Added regression tests for all four dispatch paths, verified against the
pre-fix code to confirm they fail with the original id => 0 defect
(SummitService's stays green either way, per the note above).
    @smarcet
    smarcet committed Jul 25, 2026
    Configuration menu
    Copy the full SHA
    c844acd View commit details
    Browse the repository at this point in the history
Loading