Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OpenStackweb/openstackid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f08dd62
Choose a base ref
...
head repository: OpenStackweb/openstackid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ea7c515
Choose a head ref
  • 3 commits
  • 6 files changed
  • 1 contributor

Commits on Apr 16, 2026

  1. fix(ui): unverified user (#122)

    * fix(ui): unverified user
    
    * fix(auth): null check before calling getId() in verifyEmail
    
    Split combined null/inactive check into separate guards to prevent
    "Call to a member function getId() on null" when no user is found
    for the verification token.
    smarcet committed Apr 16, 2026
    Configuration menu
    Copy the full SHA
    0508f60 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2026

  1. Configuration menu
    Copy the full SHA
    5076ed2 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2026

  1. Feature/add expands fields relations to get user by id v2 (#148)

    * feat: add fields/relations passthrough to GET /api/v1|v2/users/{id}
    
    Wires SerializerUtils::getExpand()/getFields()/getRelations() into both
    by-ID user endpoints (matching the ParametrizedGetAll pattern already
    used by list endpoints), and makes PrivateUserSerializer treat `groups`
    as a gated relation (mirroring ApiScopeGroupSerializer) instead of
    appending it unconditionally.
    
    Unblocks ftn-docsnsklz PR #76 (SDS ftn-attendee-native-realtime-comms.md,
    D38): attendee-networking-api's IDP user_updated consumer needs to fetch
    exactly fields=public_profile_allow_chat_with_me,first_name,last_name,pic
    without pulling the rest of the private profile.
    
    v1 get() also migrated from manual try/catch to the shared
    processRequest() wrapper for consistent error handling with getV2().
    
    Also fixes an unrelated pre-existing bug in UserLoginTurnstileTest where
    $testEmail/$testPassword being typed as non-nullable string caused a
    TypeError before the test's own markTestSkipped() logic could run when
    TEST_USER_EMAIL/TEST_USER_PASSWORD are unset.
    
    9 new tests added to OAuth2UserApiTest; full suite green (180 tests,
    0 failures, 7 legitimate skips).
    
    * docs(plan): mark spec as VERIFIED
    
    * chore: untrack plan file — plan docs are working artifacts, not committed
    
    * fix: document v1 expand param and add v1 default-shape regression test
    
    Address deep-review findings on PR #148:
    - OA\Get annotation for GET /api/v1/users/{id} was missing the `expand`
      parameter even though get() already passed SerializerUtils::getExpand()
      into serialize() -- the capability was live but undocumented.
    - v1 lacked a default-shape regression test symmetric with
      testGetUserByIdV2WithNoParamsReturnsSameShapeAsBefore, so the
      fields/relations passthrough's backward compatibility on v1 was only
      exercised incidentally.
    smarcet committed Jul 30, 2026
    Configuration menu
    Copy the full SHA
    ea7c515 View commit details
    Browse the repository at this point in the history
Loading