Repository navigation
Add tests for actually calling OpenModelica - #67
Merged
Merged
Conversation
sjoelund
force-pushed
the
jenkins-build-deps-image
branch
5 times, most recently
from
June 6, 2018 17:26
f7d7e9f to
92ef962
Compare
Member
Author
|
I had quite a lot of problems with OMPython sometimes hanging when trying to quit. This might be related to the problems we have with OMSimulator (@lochel). Do any of you have any better ideas? #61 related perhaps? I think one thing we did wrong was that we just checked the exit status of OMC, but this was actually never updated because we didn't poll or wait on the subprocess. |
sjoelund
force-pushed
the
jenkins-build-deps-image
branch
from
June 6, 2018 18:21
6bb2ea2 to
9527f44
Compare
sjoelund
force-pushed
the
jenkins-build-deps-image
branch
from
June 6, 2018 18:47
9527f44 to
f329f2e
Compare
sjoelund
force-pushed
the
jenkins-build-deps-image
branch
from
June 7, 2018 07:24
b27d060 to
5d1bb16
Compare
We now create a process group so we can kill OMC properly including all child processes. This makes the tests run more stable.
This fixes an issue with passing quit() to OMC in subsequent calls of OMCSessionZMQ.
sjoelund
force-pushed
the
jenkins-build-deps-image
branch
from
June 7, 2018 07:28
5d1bb16 to
485cea0
Compare
The tests are based on OpenModelica#61
adeas31
approved these changes
Jun 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58
Closes #61