Skip to content

add enhanched OMPython functionality - #18

Merged
adeas31 merged 1 commit into
OpenModelica:masterfrom
arun3688:EnhancedOMPython
Feb 2, 2017
Merged

adeas31 merged 1 commit into
OpenModelica:masterfrom
arun3688:EnhancedOMPython

Conversation

@arun3688

@arun3688 arun3688 commented Feb 2, 2017

Copy link
Copy Markdown
Collaborator

No description provided.

@adeas31
adeas31 merged commit 57a534a into OpenModelica:master Feb 2, 2017
@lochel

lochel commented Feb 2, 2017

Copy link
Copy Markdown
Member

@arun3688 What does "enhanced functionality" mean?

@arun3688

arun3688 commented Feb 2, 2017

Copy link
Copy Markdown
Collaborator Author

There are some new API functionality added, this was a part of thesis work from student sudeep, more information can be read in this file
UsersGuide_OMPythonAPI.pdf

@bilderbuchi

Copy link
Copy Markdown

@arun3688 @adeas31 does this PR supersede the PRs #7 and #8? If so, these should be closed.
Btw, thank you for adding some docstrings, and apparently fixed at least some of the things noted in #7 and #8. :-) 👍

@bilderbuchi

bilderbuchi commented Feb 3, 2017 •

Copy link
Copy Markdown

btw, the new numpy dependency is not mentioned in setup.py install_requires.

@adeas31

adeas31 commented Feb 3, 2017

Copy link
Copy Markdown
Member

@bilderbuchi I guess PR #7 and #8 are not required now. @arun3688 can you check and close them.
I have already asked @arun3688 to mention numpy dependency in setup.py

@thorade

thorade commented Feb 3, 2017

Copy link
Copy Markdown
Contributor

Consider using find_packages for the setup.py file:
http://setuptools.readthedocs.io/en/latest/setuptools.html#using-find-packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants