Replace TestNG with JUnit + Rules#143
Merged
codefromthecrypt merged 1 commit intomasterfrom Jan 25, 2015
Merged
Conversation
JUnit Rules, such as MockWebServerRule, reduce boilerplate setup present in our tests. By migrating off TestNG, and onto rules, our tests become more maintainable as JUnit is well understood.
|
NetflixOSS » feign » feign-pull-requests #11 SUCCESS |
Contributor
Author
|
note. this didn't affect any main source files, so I plan to merge it after dinner. review-after-commit is welcome if anyone feels the urge. |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jan 25, 2015
Replace TestNG with JUnit + Rules
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Replace TestNG with JUnit + Rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JUnit Rules, such as MockWebServerRule, reduce boilerplate setup present
in our tests. By migrating off TestNG, and onto rules, our tests become
more maintainable as JUnit is well understood.
Note:
Once this is in, I plan to eliminate a large amount of clutter by using assertj as opposed to assertX methods. I will also make a couple custom ones (like RequestTemplate, which is often the source of hard-to-read assertions). After this, I'll rebase my de-dagger pull request.