for those not following the pull request, I've mentioned strong preference for using java interfaces as opposed to loose relationships which can easily cause matching bugs. I'd also love to see a concrete use case we can use in examples.. For example, something real where knowing the source exception actually makes a difference in how you route a fallback.

Here's a sketch of the usage pattern I'm suggesting to address the need to capture the throwable.

  interface GitHub {
    @RequestLine("GET /repos/{owner}/{repo}/contributors")
    List<String> contributors(@Param("owner") String owner, @Param("repo") String repo);
  }

  // Advanced users can inspect the source exception in case it helps them dispatch a better
  // fallback value
  FallbackFactory<GitHub> fallbackFactory = throwable -> (owner, repo) -> {
    // TODO: figure out a realistic use case for looking at the throwable
    if (throwable instanceof IllegalArgumentException) {
      return Arrays.asList("cops");
    } else {
      return Collections.emptyList();
    }
  };

  GitHub github = HystrixFeign.builder()
                            ...
                            .target(GitHub.class, "https://api.github.com", fallbackFactory);

Prefer method with Exception argument for fallbacks #431

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions