patch assert method in CalculatorTest class - #1
Open
okpoEkpenyong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This patch proposes using 'getRightArgument()' instead of 'getSolution()' in the CalculationServiceTest class.
Description of Task to be completed?
Change 'getSolution() to 'getRightArgument()' in the calculate_returnsAModelWithARightArgument_whenGivenADivisionCalculation() method of CalculationServiceTest class.
Any background context you want to provide?
The getSolution() method is meant to return the result of dividing Dividend(leftArgument) by Divisor(rightArgument).
Refer to the calculate_returnsAModelWithALeftArgument_whenGivenADivisionCalculation() method, where the right assertThat() value was passed as argment-in this case 'getLeftArgument()'