Feat/redis mongo urllib instrumentation#1
Merged
Conversation
…ns.open pathlib helpers (Path.open/read_text/write_text) call io.open directly and never touch builtins.open, so patching only the builtin left every pathlib file access ungoverned. install_file_io now patches both names to the same governed wrapper and uninstall restores both exactly. In CPython builtins.open IS io.open and a single logical open resolves through exactly one name (direct open -> builtins, pathlib -> io), so routing both to one wrapper adds no double wrapping or double evaluation. The io.open patch is skipped when a foreign wrapper already owns it (tracked for exact restoration); the reentrancy guard is name-agnostic and unchanged.
Align hook span projection with the Temporal legacy flat contract so HTTP/DB/file/function spans go on the wire as flat Core SpanData: - drop data.otel from hook spans (flat is the wire contract; the OTel preservation blob is opt-in debug only, off by default) - always emit common root fields (parent_span_id, kind, attributes, error) and per-family root fields, null when absent - synthesize completed end_time from start_time + duration_ns for OTel-owned spans not ended at hook time - port httpx body capture via a Client.send/AsyncClient.send patch (OTel hooks cannot safely read httpx streams); requests completed now retains request body and headers - extract db_name/server_address/server_port for SQLAlchemy, dbapi and asyncpg - tighten conformance assert_hook_wire_shape to enforce the flat contract (no data, no semantic_type, all root fields present) Verified against the real Core SpanData Go struct (DisallowUnknownFields) and the packaged conformance kit.
Add the Temporal-vs-base contract matrix + implementation report and project notes (flat-span decision, httpx send-patch body-capture arch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.