Repository navigation
«Калькулятор счёта» - #1
Open
PetrovaOla wants to merge 2 commits into
Open
PetrovaOla wants to merge 2 commits into
PetrovaOla wants to merge 2 commits into
Conversation
faritowich
reviewed
Aug 21, 2023
| System.out.println("Список продуктов: "); | ||
| productList.forEach((s) -> System.out.println(s.name + " : " + s.price)); | ||
| System.out.println("Итоговая сумма: " + parseRubCase(sum)); | ||
| System.out.println("Итоговая сумма на каждого человека: " + parseRubCase(sum / count)); |
There was a problem hiding this comment.
Такие подряд идущие println лучше объединять в один.
| while (count < 2); | ||
| } | ||
|
|
||
| private static void addProductList(int count) { |
There was a problem hiding this comment.
Хорошо, что логика разнесена по разным методам, но лучше их была разнести и по разным классам, потому что у них совсем уж разные зоны ответственности
| } | ||
| } | ||
|
|
||
| while (count < 2); |
There was a problem hiding this comment.
Этот логический блок также имело смысл вынести в отдельный метод, как это сейчас сделано с другими (ввод и обработка товаров, вывод окончания и тд)
| do { | ||
| System.out.println("Введите цену товара в формате рубли.копейки"); | ||
| String str = scanner.next(); | ||
| if (str.trim().toUpperCase().toLowerCase().contains("завершить")) { |
| active = false; | ||
| break; | ||
| } | ||
| if (!str.matches("[0-9]+\\.[0-9]+")) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Консольное приложение №1
«Калькулятор счёта»