Fix cleanup config files - #8761
Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits intoJan 30, 2019
Merged
Conversation
Ilya (iSazonov)
requested review from
Steve Lee (SteveL-MSFT),
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
January 28, 2019 04:47
Reece Dunham (RDIL)
approved these changes
Jan 28, 2019
Steve Lee (SteveL-MSFT)
requested changes
Jan 28, 2019
| { | ||
| File.Delete(systemWideConfigFile); | ||
| } | ||
| var count = 10; |
There was a problem hiding this comment.
maxPause is better than count
Collaborator
Author
|
Steve Lee (@SteveL-MSFT) Please update your review. |
Steve Lee (SteveL-MSFT)
approved these changes
Jan 29, 2019
11 tasks
Aditya Patwardhan (adityapatwardhan)
approved these changes
Jan 29, 2019
Aditya Patwardhan (adityapatwardhan)
added
the
CL-Test
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #8715.
Add attempts to delete configuration files.
PR Context
There sometimes is a race condition in xUnit tests - powershell.config.json file is blocked in one process and another process tries to remove the file.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests