Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Nomifactory/GregTech
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Nomifactory/GregTech
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: FluidRegulatorNewKeepExactAlgorithm
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 15, 2021

  1. New algorithm for Fluid Regulator Keep Exact Mode 

    Fixes #1705, Supersedes #1710

The existing algorithm was buggy and the proposed rework was hard to
follow the logic, so I came up with a more straightforward algorithm
which should be easier to understand and maintain.

I have also created some tests to demonstrate the functionality of the
revised algorithm and ensure that the behavior is the same as before,
besides the bug.
    @Exaxxion
    Exaxxion committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    4a757b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. Reindent using spaces.

    @Exaxxion
    Exaxxion committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    23158f6 View commit details
    Browse the repository at this point in the history

  2. Remove redundant non-null filter

    @Exaxxion
    Exaxxion committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    a6dbd00 View commit details
    Browse the repository at this point in the history

  3. Fix some shortcomings with unit tests

    @Exaxxion
    Exaxxion committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    05fa60d View commit details
    Browse the repository at this point in the history
Loading