test(e2e): add nominal tests for exec & init CLI commands#434
Merged
Conversation
ErwanRaulo
force-pushed
the
test-cli-integration
branch
2 times, most recently
from
9425a2f to
bae3766
Compare
ErwanRaulo
commented
Jan 1, 2025
fraxken
reviewed
Jan 3, 2025
Member
|
Hi @ErwanRaulo
I don't have this problem, are you sure you built the project first ? |
ErwanRaulo
force-pushed
the
test-cli-integration
branch
from
bae3766 to
1c7450a
Compare
Member
PierreDemailly
left a comment
PierreDemailly
left a comment
There was a problem hiding this comment.
Nit picks, this is good job 💪
Contributor
Author
|
Thanks for feedback, I will correct them all soon. And yes I can run " nreport init " now, don't known if it was thanks to the latest commit or my fault but in my TS migration PR I've used rimraf also. |
ErwanRaulo
force-pushed
the
test-cli-integration
branch
from
1c7450a to
e503073
Compare
ErwanRaulo
force-pushed
the
test-cli-integration
branch
from
e503073 to
6b1ab6c
Compare
fraxken
reviewed
May 9, 2025
no breaking changes use childprocess to collect CLI stdout missing limit case tests fix NodeSecure#395
ErwanRaulo
force-pushed
the
test-cli-integration
branch
from
6b1ab6c to
ecdb9f4
Compare
fraxken
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOFIX: could run tests before TS migration, now something goes wrong with childprocess and execution path.
when running nreport init, main process throws the same error :
Error: ENOENT: no such file or directory, open 'C:<yourDevDir>\report\dist\views\template.html'
process try to access views from dist folder but it does not exists, should be added to dist folder as asset in tsconfig file to include a copy when compiling typescript