This repository was archived by the owner on Aug 14, 2024. It is now read-only.
add NodeSecure Report configuration#8
Merged
Merged
Conversation
Kawacrepe
reviewed
Mar 27, 2022
Member
Kawacrepe
left a comment
Kawacrepe
left a comment
There was a problem hiding this comment.
Neat, I just added a question in comments and maybe we should update the "Generation" part in README, adding the "report" configuration mode ?
tony-go
approved these changes
Mar 30, 2022
Member
tony-go
left a comment
tony-go
left a comment
There was a problem hiding this comment.
LGTM, except the assertion I mentioned. 👏
fraxken
force-pushed
the
report-configuration
branch
from
2056ad2 to
7fe1c11
Compare
refactor(jsonSchema): split definitions in multiple .json file and add helpers to load the configuration feat: add ReportConfiguration JSON Schema & defs chore: review test: enhance rc.spec.ts titles test: enhance test title
fraxken
force-pushed
the
report-configuration
branch
from
d778c87 to
1abc876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement a first draft of configuration for the NodeSecure report project.
I made some modifications to allow a better integration of the future configuration:
./src/projects