Fix wip 7.1 test failures#2663
Conversation
There was a problem hiding this comment.
This branch will not be merged before 7.1.0 is on the table, anyway. I'd rather not have all of this version-checking code for a situation that we won't ever find ourselves in. Instead, you should increase the version in version.txt to 7.1.0-beta1 and then run resaveModels again so they all get saved with the right version and spacing.
37c879c to
466307f
Compare
466307f to
5d0d814
Compare
Point it to a version with newlines around code/info section.
111e009 to
68f1a2e
Compare
|
PR for resaved models: NetLogo/models#449 |
|
I think there's something weird going on with GitHub Actions. 68f1a2e shouldn't be able to pass the tests until NetLogo/models#449 is merged, but somehow it did. Now that it's actually merged, it's back to failing the tests again. |
|
@kgmt0 If you look at the tests that are currently failing on |
That's even more strange. How did the same failures not happen for 68f1a2e? The exact same commit in my fork has failing tests.
The commit only exists in my own fork right now. I haven't pushed anything to official models repo yet. |
|
Hmm, that does sound wrong. GitHub has apparently been having database issues recently, so maybe that's the explanation? |
This fix test failures that occurred following the merge of #2633.