Skip to content

Fix wip 7.1 test failures#2663

Merged
TheBizzle merged 4 commits into
NetLogo:wip-7.1from
kgmt0:fix-wip-7.1-test-failures
May 1, 2026
Merged

Fix wip 7.1 test failures#2663
TheBizzle merged 4 commits into
NetLogo:wip-7.1from
kgmt0:fix-wip-7.1-test-failures

Conversation

@kgmt0

@kgmt0 kgmt0 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

This fix test failures that occurred following the merge of #2633.

@kgmt0

kgmt0 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

The models still need to be resaved, but we need to bump the version number before doing that. 85178a5 and dffed1b only add/strip newlines if the version number is 7.1.0 or higher, so just resaving the models now will break some tests.

@kgmt0 kgmt0 requested a review from TheBizzle April 30, 2026 08:11

@TheBizzle TheBizzle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch will not be merged before 7.1.0 is on the table, anyway. I'd rather not have all of this version-checking code for a situation that we won't ever find ourselves in. Instead, you should increase the version in version.txt to 7.1.0-beta1 and then run resaveModels again so they all get saved with the right version and spacing.

@kgmt0 kgmt0 force-pushed the fix-wip-7.1-test-failures branch 3 times, most recently from 37c879c to 466307f Compare April 30, 2026 21:54
@kgmt0 kgmt0 force-pushed the fix-wip-7.1-test-failures branch from 466307f to 5d0d814 Compare April 30, 2026 22:25
@kgmt0 kgmt0 force-pushed the fix-wip-7.1-test-failures branch 2 times, most recently from 111e009 to 68f1a2e Compare April 30, 2026 23:37
@kgmt0

kgmt0 commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

PR for resaved models: NetLogo/models#449

@TheBizzle TheBizzle merged commit e1d3610 into NetLogo:wip-7.1 May 1, 2026
40 of 41 checks passed
@kgmt0

kgmt0 commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

I think there's something weird going on with GitHub Actions. 68f1a2e shouldn't be able to pass the tests until NetLogo/models#449 is merged, but somehow it did. Now that it's actually merged, it's back to failing the tests again.

@ERSUCC

ERSUCC commented May 1, 2026

Copy link
Copy Markdown
Contributor

@kgmt0 If you look at the tests that are currently failing on wip-7.1, they don't seem to relate at all to the models repo, so I think they are unrelated. Also, I don't see why the commit you referenced should have failed the tests, because even though you didn't merge the PR in the models repo, you still pointed this PR to the correct commit in the models repo.

@kgmt0

kgmt0 commented May 2, 2026

Copy link
Copy Markdown
Contributor Author

If you look at the tests that are currently failing on wip-7.1, they don't seem to relate at all to the models repo, so I think they are unrelated.

That's even more strange. How did the same failures not happen for 68f1a2e? The exact same commit in my fork has failing tests.

Also, I don't see why the commit you referenced should have failed the tests, because even though you didn't merge the PR in the models repo, you still pointed this PR to the correct commit in the models repo.

The commit only exists in my own fork right now. I haven't pushed anything to official models repo yet.

@ERSUCC

ERSUCC commented May 2, 2026

Copy link
Copy Markdown
Contributor

Hmm, that does sound wrong. GitHub has apparently been having database issues recently, so maybe that's the explanation?

@kgmt0 kgmt0 deleted the fix-wip-7.1-test-failures branch June 18, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants