Add the monstercolor system, letting players choose monster colors#437
Open
copperwater wants to merge 1 commit intoNetHack:NetHack-3.7from
Open
Add the monstercolor system, letting players choose monster colors#437copperwater wants to merge 1 commit intoNetHack:NetHack-3.7from
copperwater wants to merge 1 commit intoNetHack:NetHack-3.7from
Conversation
copperwater
force-pushed
the
monstercolor
branch
from
3d4ac18 to
091eb40
Compare
copperwater
force-pushed
the
monstercolor
branch
from
5ad131e to
fcb25b7
Compare
This existed as one of the 3.4.3-nao patches, but rather than porting that patch to the current codebase I started from scratch, because the system as I saw it had two big drawbacks: 1. Mutated mons[], which is just not a great idea in my book. 2. Colors were only settable via config file, not in-game. I envisioned monster colors working like msgtypes or autopickup exceptions, which can be modified in-game. To that end, monstercolors are settable in-game via a submenu in the "Other settings" section of the options, like autopickup exceptions or msgtypes, as well as via "MONSTERCOLOR=monname:color" in the config. Also like those settings, they do not persist through saving and restoring, but any config lines will be loaded as normal upon restore. Instead of directly editing mons[], it edits a new variable 'monstercolors' in instance_globals. I thought this might be unnecessary at first, but then realized that if it changed mons[].mcolor like the NAO patch, then it would be impossible to count the number of currently set monstercolors because there would be no default to compare against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This existed as one of the 3.4.3-nao patches, but rather than porting that patch to the current codebase I started from scratch, because the system as I saw it had two big drawbacks:
To that end, monstercolors are settable in-game via a submenu in the "Other settings" section of the options, like autopickup exceptions or msgtypes, as well as via "MONSTERCOLOR=monname:color" in the config. Also like those settings, they do not persist through saving and restoring, but any config lines will be loaded as normal upon restore.
Instead of directly editing mons[], it edits a new variable 'monstercolors' in instance_globals. I thought this might be unnecessary
at first, but then realized that if it changed mons[].mcolor like the NAO patch, then it would be impossible to count the number of currently set monstercolors because there would be no default to compare against.