Open
Conversation
Initial HTML Dumplog implementation. This extends the dumplog 'windowport' paradigm, and dumps text and HTML dumplogs in parallel (though it is possible to configure just one or the other via sysconf, or by enabling DUMPLOG/DUMPHTML macros independently at compile time). This commit incorporates contributions by: - Tangles (most of the code and logic) - K2 and bhaak (various formatting and CSS improvements) Original concept (and CSS) from UnNetHack.
also add html dumplogs to Guidebook.tex. Did not modify other guidebooks yet.
Contributor
Author
|
This feature adds a lot of extra code to windows.c that doesn't really belong there. I was considering moving all the dump code to a new file (dump.c?), but this would be difficult to maintain separately if it does not get merged (since it would also move a lot of existing code). I'd definitely be prepared to do that work and PR it if this one gets merged. |
nhcopier
pushed a commit
that referenced
this pull request
Mar 30, 2024
This doesn't directly affect nethack, but it should prevent HTML dumplog for variants that include that from showing T-shirt and apron slogan text in tooltips for the 'gameover' map. And it makes end-of-game attribute disclosure slightly less susceptible to being unintentionally reverted. Code in pull request #300 shows that it uses do_screen_description() for tooltips and do_screen_description() uses distant_name() for objects so that's where I added this change that will trigger the code from commit c699277.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my current work on HTML dump logs, for your consideration. This code is live on the hardfought servers. (sample: https://au.hardfought.org/userdata/T/Tangles/nethack/dumplog/1580642779.nh.html)
Please let me know if I can do anything to help you get it merged.
Thanks
Tangles.