Skip to content

Label font size doesn't match --const-font-size #220

Open

Description

@mukaschultze

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.1.2
  • Cross-platform modules: 6.1.2
  • Android Runtime: 6.1.2
  • iOS Runtime: 6.1.0
  • Plugin(s):

Describe the bug

Default font size is set to 10, although the --const-font-size is 12.

This seems to be a regression from v2.1.2, as it only happens on v2.2.0. Below is a comparison between v2.1.2 (left) and v2.2.0 (right):

FotoJet

To Reproduce

<Label text="Font size: 8" fontSize="8"></Label>
<Label text="Font size: 9" fontSize="9"></Label>
<Label text="Font size: 10" fontSize="10"></Label>
<Label text="Font size: 11" fontSize="11"></Label>
<Label text="Font size: 12" fontSize="12"></Label>
<Label text="Font size: Default"></Label>
<Label text="Font size: 13" fontSize="13"></Label>
<Label text="Font size: 14" fontSize="14"></Label>
<Label text="Font size: 15" fontSize="15"></Label>

Expected behavior

Label font size should be 12 or --const-font-size variable should be 10.
Code where font-size is set to 10

Sample project

Additional context

I'm using Kendo UI default theme

Activity

  1. bundyo commented on Nov 7, 2019

    @bundyo
    Contributor

    Thanks for the report!

  2. self-assigned this
    on Nov 7, 2019
  3. bundyo commented on Nov 7, 2019

    @bundyo
    Contributor

    Interestingly I couldn't reproduce this here. However I noticed that $font-size is declared twice, so I removed one and adjusted the size classes. Default size should be 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions