This repository was archived by the owner on Feb 7, 2019. It is now read-only.
Repository navigation
Push plugin does not work on Android with NativeScript 2.3 - #46
Closed
manojdcoder wants to merge 2 commits into
Closed
manojdcoder wants to merge 2 commits into
manojdcoder wants to merge 2 commits into
Conversation
manojdcoder
changed the title
manojdcoder
changed the title
Contributor
|
@manojdcoder Thank you very much for your contribution - it really helped resolve the run-time issue. However, we decided to go with referencing the latest available version of the Google Play Services SDK on the server (using +). Also, can you please specify why is the ACCESS_NETWORK_STATE PERMISSION required? I am not sure if this is needed for the logic to work out of the box. I will close this PR for now because I already submitted one with changing the gradle dependency with +. |
Author
|
@AntonDobrev I'm not really sure why GCM requires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #12