This repository was archived by the owner on Feb 7, 2019. It is now read-only.
Repository navigation
Fritzvd/extra parameters for callback - #11
Merged
Merged
Conversation
It seems like a good idea to read out other things then just the message. Backwards compatibility is ensured by still sending the message as a first parameter. In these examples: https://developers.google.com/cloud-messaging/downstream#receiving-messages-on-an-android-client-app it would seem that that is the intention of the message. I'm not quite sure if this will work though, because I couldn't find a 'how-to-contribute' kind of page. So I'm not sure how to build the `.jar` that's a part of the npm package. Let me know what you think of this change.
* Java Bundle as json, to string.. which is meh 😵
Contributor
Author
|
PR #4 moved here. |
r0bot
added a commit
that referenced
this pull request
Jan 21, 2016
…back Fritzvd/extra parameters for callback
r0bot
merged commit Jan 21, 2016
a0664fa
into
NativeScript:pzlatanov/android-full-object-to-callback
|
@twistedSynapse and @fritzvd : Thank you! |
Contributor
|
Very cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request of the changes proposed by @fritzvd moved to this branch for polishing and testing and will later be merged in master.