You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 7, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 7, 2019. It is now read-only.
Should we keep didRegisterForRemoteNotificationsWithDeviceToken callback? #209
On the callback for didRegisterForRemoteNotificationsWithDeviceToken on LINE 114 it removes the observer for that event. My concern is that in the Apple Documentation Configuring Remote Notification Support (in the Obtaining a Device Token in iOS and tvOS section) it indicates that if the APNs Device Token changes while your app is running it will invoke the didRegisterForRemoteNotificationsWithDeviceToken callback again with the new Device Token.
NOTE
If the device token changes while your app is running, the app object calls the appropriate delegate method again to notify you of the change.
Should we really be removing this handler? It seems like the handler should stay in place so that it can handle new Device Tokens.
On the callback for
didRegisterForRemoteNotificationsWithDeviceTokenonLINE 114it removes the observer for that event. My concern is that in the Apple Documentation Configuring Remote Notification Support (in the Obtaining a Device Token in iOS and tvOS section) it indicates that if the APNs Device Token changes while your app is running it will invoke thedidRegisterForRemoteNotificationsWithDeviceTokencallback again with the new Device Token.Should we really be removing this handler? It seems like the handler should stay in place so that it can handle new Device Tokens.
push-plugin/src/push-plugin.ios.ts
Lines 113 to 118 in a096afc
I'm totally new to mobile dev and just happened to be reading the Apple Docs to make sure I understood how this stuff works.