Repository navigation
Fix file references inside .pbxproject - #9
Merged
Merged
Conversation
mbektchiev
approved these changes
Jul 4, 2018
Fatme
force-pushed
the
fatme/fix-file-references
branch
2 times, most recently
from
July 5, 2018 07:55
be694ed to
225bb32
Compare
Fatme
force-pushed
the
fatme/fix-file-references
branch
from
July 5, 2018 08:28
225bb32 to
bd5622d
Compare
mbektchiev
approved these changes
Jul 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{N} CLI is not able to build a native project in case when the project name contains a space. In this case the filePaths inside HEADER_SEARCH_PATHS sections are not valid. Actually this PR fixes 2 problems.
The first is that the added filePath is full file path, so this PR changes this and makes the paths relative.
The second thing is that the filePath does not contain " ", so this PR adds "" around the filePath.
Steps to reproduce:
tns create "my space app"tns-core-modulesto nexttns build ios