Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test apps-automated -c=android |
❌ Failed | 3m 46s | View ↗ |
nx run-many --target=test --configuration=ci --... |
✅ Succeeded | 3s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-03-12 20:52:38 UTC
- fall back to plain UIVisualEffectView when glass APIs are unavailable - guard glass effect runtime access behind capability checks - request layout for iOS 18+ label text changes even for fixed-size labels - add automated regression coverage for liquid glass effect updates
packages/core/ui/label/index.ios.ts
Outdated
| if (this._fixedSize === FixedSize.WIDTH && !this.textWrap && this.getMeasuredHeight() > 0) { | ||
| // Single line label with fixed width will skip request layout on text change. | ||
| return; | ||
| if (SDK_VERSION < 18) { |
There was a problem hiding this comment.
@VeinDevTtv How does this change affect liquid glass flex?
Because if you did that to make the failing test pass, it's irrelevant and not very desirable.
We should track the real cause of it failing and why the check is there to begin with.
Update the iOS LiquidGlass FlexboxLayout test to compare the fixed 300 DIP container height using device pixels. The layout helper reports pixel sizes, so 300 DIP correctly renders as 900 px on a 3x simulator; this fixes an outdated test expectation rather than a flexbox regression.
packages/core/utils/constants.ios.ts
Outdated
| export const SDK_VERSION = parseFloat(UIDevice.currentDevice.systemVersion); | ||
|
|
||
| function hasRuntimeGlobal(name: 'UIGlassEffect' | 'UIGlassContainerEffect' | 'UIGlassEffectStyle'): boolean { | ||
| return typeof (globalThis as any)?.[name] !== 'undefined'; |
There was a problem hiding this comment.
Better to just rely on the SDK_VERSION check alone. runtime global checks like this shouldn't be needed when the SDK level is the best defining line. In other words, the supportsGlass check should be sufficient alone without this.
Remove the unrelated Label layout invalidation change and simplify glass support back to the SDK gate requested in PR review. Also drop runtime glass style global lookups and restore temporary measure-state overrides in finally blocks so the flexbox fix remains scoped and safe.
3 participants
PR Checklist
What is the current behavior?
Currently on iOS, placing a
LiquidGlassorLiquidGlassContainercomponent inside aFlexboxLayoutcompletely breaks the layout (children are measured incorrectly and positioned at the wrong coordinates). This is because LiquidGlass overrides_addViewToNativeVisualTreeto use a nested_contentHostview, which mismatches FlexboxLayout's standard measurement and layout paradigms.What is the new behavior?
Measurement fix: Overrode
onMeasurein bothLiquidGlassandLiquidGlassContainerto temporarily zero out padding/border properties before delegating tosuper.onMeasure(). This preventsGridLayout/AbsoluteLayoutfrom double-subtracting padding thatFlexboxLayoutalready removed from the child measure spec.Layout fix: Overrode
onLayoutin both classes to callsuper.onLayout(0, 0, right - left, bottom - top). SinceFlexboxLayoutpositions the rootUIVisualEffectViewusing absolute coordinates, the internal NativeScript layout engine needs normalized(0, 0, width, height)bounds to correctly position children within the local_contentHostcoordinate space.Fixes #11099.