fix(ios): secureWithoutAutofill on TextField#11129
Conversation
|
View your CI Pipeline Execution ↗ for commit d3bd6e9
☁️ Nx Cloud last updated this comment at |
| return; | ||
| } | ||
|
|
||
| const nativeField = textField as any; |
There was a problem hiding this comment.
Is cast to any necessary here? I understand these props are available in UITextField.
There was a problem hiding this comment.
Some properties are sdk level scoped so we can probably rather use SDK_VERSION scope on some.
| */ | ||
| textField.secureTextEntry = true; | ||
| } | ||
| this._applySecureWithoutAutofillTraits(textField); |
There was a problem hiding this comment.
Maybe we need an extra flag to determine if the native props have already been updated and reduce _applySecureWithoutAutofillTraits calls since there are cases like reloadInputViews() that might be called multiple times while typing.
For instance, the old fix made sure to check whether secureTextEntry was already enabled or not before proceeding.
CatchABus
left a comment
CatchABus
left a comment
There was a problem hiding this comment.
I see the PR got merged but I'll leave a couple of comments here.
3 participants
secureWithoutAutofillonTextFieldwith iOS to ensure it applies at the right time to prevent the autofill handling