feat(vite): improved workspace and windows compatibility#10959
Open
NathanWalker wants to merge 42 commits intomainfrom
Open
feat(vite): improved workspace and windows compatibility#10959NathanWalker wants to merge 42 commits intomainfrom
NathanWalker wants to merge 42 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 0e886e2
☁️ Nx Cloud last updated this comment at |
NathanWalker
force-pushed
the
feat/vite-improvements
branch
4 times, most recently
from
a4a2258 to
74c041a
Compare
NathanWalker
force-pushed
the
feat/vite-improvements
branch
from
74c041a to
6de0d07
Compare
NathanWalker
force-pushed
the
feat/vite-improvements
branch
from
b6f85fc to
40788e3
Compare
…k for quick core build verify against apps
Type checking diagnostics come from the project's `tsconfig.json`. By default, the build follows `compilerOptions.noEmitOnError` to decide whether type errors should fail the build. If you want to override that behavior for Vite, pass a `typeCheck` option to the framework helper.
CatchABus
reviewed
Mar 12, 2026
CatchABus
reviewed
Mar 15, 2026
| indexAsInt--; | ||
| } | ||
| } else if (types.isString(index)) { | ||
| while (result && result.typeName !== index) { |
Contributor
There was a problem hiding this comment.
What is the intention of this change? Something to do with Vite having trouble to parse keys of $parents references in XML?
Contributor
Author
There was a problem hiding this comment.
Good question, it makes string-based ancestor lookup compat with Vite runtime naming differences, where relying on typeName alone is brittle. Now, bindings like $parents['StackLayout'] can still resolve even if the runtime name is unstable, because the fallback uses cssType = stacklayout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.