Skip to content

REopt.jl v0.47.0#586

Merged
Bill-Becker merged 3 commits into
developfrom
reoptjl-v0470
Jun 4, 2024
Merged

REopt.jl v0.47.0#586
Bill-Becker merged 3 commits into
developfrom
reoptjl-v0470

Conversation

@Bill-Becker
Copy link
Copy Markdown
Collaborator

@Bill-Becker Bill-Becker commented Jun 1, 2024

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

What is the current behavior?

(You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Other information:

@Bill-Becker
Copy link
Copy Markdown
Collaborator Author

Bill-Becker commented Jun 3, 2024

@hdunham @bpulluta @zolanaj @adfarth You all made commits in the REopt.jl v0.47.0 release. Please add/update what you need to for the API, and when you finished, please drop a note saying so.

@bpulluta I believe I added the new ProcessHeatLoadInputs, but let me know if anything else has to be added (I don't think outputs/results need to be added).

@adfarth
Copy link
Copy Markdown
Collaborator

adfarth commented Jun 3, 2024

@hdunham @bpulluta @zolanaj @adfarth You all made commits in the REopt.jl v0.47.0 release. Please add/update what you need to for the API, and when you finished, please drop a note saying so.

@bpulluta I believe I added the new ProcessHeatLoadInputs, but let me know if anything else has to be added (I don't think outputs/results need to be added).

@Bill-Becker confirming that no changes need to be made for the commits I made in v0.47.0.

@hdunham
Copy link
Copy Markdown
Collaborator

hdunham commented Jun 4, 2024

@hdunham @bpulluta @zolanaj @adfarth You all made commits in the REopt.jl v0.47.0 release. Please add/update what you need to for the API, and when you finished, please drop a note saying so.

@bpulluta I believe I added the new ProcessHeatLoadInputs, but let me know if anything else has to be added (I don't think outputs/results need to be added).

No API changes are needed for my Julia PRs.

hdunham
hdunham reviewed Jun 4, 2024
View reviewed changes
Comment thread reo/scenario.py Outdated
@Bill-Becker Bill-Becker marked this pull request as ready for review June 4, 2024 17:42
@zolanaj
Copy link
Copy Markdown
Collaborator

zolanaj commented Jun 4, 2024 •
edited
Loading

@hdunham @bpulluta @zolanaj @adfarth You all made commits in the REopt.jl v0.47.0 release. Please add/update what you need to for the API, and when you finished, please drop a note saying so.

@bpulluta I believe I added the new ProcessHeatLoadInputs, but let me know if anything else has to be added (I don't think outputs/results need to be added).

Confirming no API changes required for my commits in v0.47.0.

@Bill-Becker Bill-Becker merged commit 8f3dfe8 into develop Jun 4, 2024
@Bill-Becker Bill-Becker deleted the reoptjl-v0470 branch June 4, 2024 20:01
@Bill-Becker Bill-Becker mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hdunham hdunham hdunham left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bill-Becker @adfarth @hdunham @zolanaj