Add CHP, /chp_defaults, and /simulated_load end to /dev for v3#382
Merged
Conversation
note: adds an additional validation check not in the Julia package that compares the length of installed_cost_per_kw and tech_sizes_for_cost_curve
…_cost_curve, unavailability_periods
Fix syntax error for CHP defaults from REopt.jl
prime_mover is not required, size_class default based on logic
Defaults come from REopt.jl now
prime_mover is not required, but fuel_cost_per_mmbtu is
Not sure why the last update didn't do this
add capability to job/ app (API v3 using REopt.jl backend) to handle CHP
zolanaj
approved these changes
Nov 29, 2022
Collaborator
zolanaj
left a comment
zolanaj
left a comment
There was a problem hiding this comment.
The changelog update looks good to me, and the lone commit that is in master but not develop is a PR merge with no changed files, so we can merge this (and perhaps do a develop <-- master merge right after). Thanks @Bill-Becker!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR #340.