/stable points to v2 reo/job#342
Merged
Merged
Conversation
missing -1 in indexing was causing BAU problem to be infeasible when existing techs could sustain part of outage
Add off-grid capability to API v3, add name changes to include before/after tax in result keys to api output models.
Document changes made via help_text / comments. Updated Changelog.md to reflect changes as well.
Add the ability to set run_bau to false for off-grid runs
Add the ability to override conditional defaults which are set based on off-grid flag.
Outage timestep corrections
Clean up when electrictariff is cleaned if off-grid flag is true, update electrictariff error messages and info messages to alert users that electrictariff is not used when off-grid is true.
update requirements.txt for security patches
- Updated validation and endpoint tests for off-grid functionality - Updated migration file to contain all updates/additions in the same file - Updated changelong
Added additional input validations to determine if any input keys are not accepted when off_grid is true to avoid errors from REopt.jl. Added message to users to alert them of techs which can be modeled if off_grid is true.
Add off-grid capability and input/output field name changes (i.e. tax suffixes)
avoid triggering duplicate github workflows
because reo/api.py now has Resources defined for versions 1 and 2
hdunham
approved these changes
Jul 26, 2022
Collaborator
hdunham
left a comment
hdunham
left a comment
There was a problem hiding this comment.
Looks good. I edited the description to mention the other bug fixes that are included in this PR besides pointing stable to the correct version. I also added a couple other minor commits to make sure the correct version meta data gets returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
I deployed
developto the development server and tested that we are getting the new defaultsWhat kind of change does this PR introduce?
v2for/stable/jobadditions for v3 development, see Add off-grid capability and tax suffixes #328What is the current behavior?
/stableURL for the/jobendpoint uses Job() API which is thev1versionWhat is the new behavior (if this is a feature change)?
/stablenow uses theJob2()API which is the v2 version ofreoDoes this PR introduce a breaking change?
Yes, for
/stable/jobendpoint, but this fixes what was broken because we had intended/stableto bev2Other information: