add capability to job/ app (API v3 using REopt.jl backend) to handle CHP#340
Conversation
note: adds an additional validation check not in the Julia package that compares the length of installed_cost_per_kw and tech_sizes_for_cost_curve
Fix syntax error for CHP defaults from REopt.jl
prime_mover is not required, size_class default based on logic
Defaults come from REopt.jl now
prime_mover is not required, but fuel_cost_per_mmbtu is
|
@zolanaj Still waiting on the results of the test suite, but this should be good to re-review for you - I'll debug any tests that are still failing. I made pretty sweeping changes of your implementation of CHP defaults and validation - sorry about that, I didn't realize the most efficient way forward was to use REopt.jl's REoptInputs.s (Scenario) to assign the defaults back to models.py CHPInputs fields until after I was way into it. I made equivalent tests of the tests that you made for CHP defaults and validation, consistent with the revised processing. Note, this branch is currently using the simulated-load branch of REopt.jl because it has integrated some of those features. We'll have to merge that stuff into REopt.jl master before merging this. |
Not sure why the last update didn't do this
Bill-Becker
left a comment
Bill-Becker
left a comment
There was a problem hiding this comment.
I updated to the latest published version of REopt now that the simulated-load branch was merged in.
zolanaj
left a comment
zolanaj
left a comment
There was a problem hiding this comment.
Thanks for all the work on this @Bill-Becker! This looks ready to merge to me. In addition to handling some merge conflicts with devleop in Manifest.toml, The only things I added were a couple small tests to ensure that bad and missing inputs in the simulated_load function were returning the errors we expect. Once the tests pass, I think this is good to go.
3 participants
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Add capability to job/ app (API v3 using REopt.jl backend) to handle CHP technology